Skip to content

Conversation

@Henkhogan
Copy link

@Henkhogan Henkhogan commented Jan 4, 2025

Fixes #355

@Henkhogan Henkhogan changed the title Allow to opt out from special naming when fieldname ends with _id #355 Allow to opt out from special naming when fieldname ends with _id Jan 4, 2025
@coveralls
Copy link

coveralls commented Jan 23, 2025

Coverage Status

coverage: 97.035% (+0.01%) from 97.025%
when pulling 138cb25 on Henkhogan:master
into 82251f3 on agronholm:master.

@sheinbergon
Copy link
Collaborator

@agronholm Given the tests are fixed. How do you feel about merging this PR?

@sheinbergon sheinbergon added this to the 3.1.x milestone Oct 18, 2025
@sheinbergon sheinbergon self-assigned this Oct 18, 2025
@sheinbergon
Copy link
Collaborator

@agronholm Given the tests are fixed. How do you feel about merging this PR?

@agronholm would love to hear your opinion

@agronholm
Copy link
Owner

I guess I'm okay with it.

@agronholm
Copy link
Owner

Needs a changelog entry too.

@sheinbergon
Copy link
Collaborator

@Henkhogan would you mind remdying your PR? Fix the tests to meet latest version changes + add change log entry?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow to opt out from special naming when fieldname ends with _id

4 participants