-
Notifications
You must be signed in to change notification settings - Fork 3
feat: bring dockerfile into OSRB compliance #337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Harrison Saturley-Hall <[email protected]>
WalkthroughIntroduces an Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant SRC as Source
participant ENV as env-builder (builder stage)
participant FINAL as distroless final
SRC->>ENV: COPY source files\ncreate venv at /opt/$APP_NAME/venv
note right of ENV #D3E4CD: Sync deps\nuv pip install --no-deps\ninstall project into venv
ENV-->>FINAL: COPY venv and app artifacts
FINAL->>FINAL: Set VIRTUAL_ENV and PATH
FINAL->>Container: ENTRYPOINT aiperf
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
Dockerfile(2 hunks)
🧰 Additional context used
🪛 Hadolint (2.14.0)
Dockerfile
[error] 89-89: COPY with more than 2 arguments requires the last argument to end with /
(DL3021)
Signed-off-by: Harrison Saturley-Hall <[email protected]>
Signed-off-by: Harrison Saturley-Hall <[email protected]>
|
I get a permission denied when it tries to create the artifacts/logs directories, but likely just needs some volume mounting |
This changes to an NVIDIA-approved base container which is a distroless python 3.12 to speed compliance approval.
Relates to OPS-1285
Summary by CodeRabbit
Refactor
Chores