Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing GROK model provider key initialization #296

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

FabriceIRANKUNDA
Copy link
Collaborator

Relates to:

#295

Risks

Low: This change is low risk, as it only introduces a new case for an additional model provider in an existing switch statement.

Background

What does this PR do?

This PR adds initialization for the GROK model provider key in the getTokenForProvider function. Previously, the function did not handle the GROK model provider, potentially leading to issues if the provider was selected without a corresponding key.

What kind of change is this?

  • Feature: This is a non-breaking change that adds functionality by supporting a new model provider (GROK).

Documentation changes needed?

Yes

Testing

Where should a reviewer start?

The review should focus on the getTokenForProvider function in the relevant file, ensuring that the added GROK case aligns with the structure of other model provider cases.

Detailed testing steps

  • Confirm that selecting ModelProviderName.GROK successfully returns the appropriate API key from character.settings?.secrets?.GROK_API_KEY or settings.GROK_API_KEY.

Deploy Notes

No special deployment instructions.

Database changes

None.

Deployment instructions

Standard deployment steps apply.

@lalalune lalalune merged commit 8af7170 into main Nov 13, 2024
1 check passed
@lalalune lalalune deleted the Ft-Grok-Model-Provider branch November 13, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants