Tests: Support sqlite aiida fixtures when available #677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #677 +/- ##
==========================================
- Coverage 84.29% 84.20% -0.09%
==========================================
Files 18 18
Lines 3584 3589 +5
==========================================
+ Hits 3021 3022 +1
- Misses 563 567 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
danielhollas
commented
Feb 6, 2025
| def aiida_local_code_bash(aiida_local_code_factory): | ||
| """Return a `Code` configured for the bash executable.""" | ||
| return aiida_local_code_factory(executable="bash", entry_point="bash") | ||
| def aiida_local_code_bash(aiida_code_installed): |
Contributor
Author
There was a problem hiding this comment.
The new fixtures have aiida_code_installed instead of aiida_local_code_factory.
danielhollas
force-pushed
the
sqlite-fixtures
branch
from
aea5749 to
6785bc0
Compare
This reverts commit 571f006.
danielhollas
commented
May 14, 2025
danielhollas
force-pushed
the
sqlite-fixtures
branch
from
4efeef6 to
b78fe2e
Compare
danielhollas
added
testing
and removed
blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sqlite-based test fixtures has been available since AiiDA 2.6, but the sqlite backend was missing a support for
has_keyin QueryBuilder that we use in AWB. This support was added in 2.7, hence we gate the new fixtures by this version. For older versions, we will still run the test suite with old test fixtures that require PGSQL.