Remove BandsDataViewer and bokeh dependency#734
Open
danielhollas wants to merge 3 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #734 +/- ##
==========================================
- Coverage 85.09% 84.99% -0.10%
==========================================
Files 18 18
Lines 3394 3373 -21
==========================================
- Hits 2888 2867 -21
Misses 506 506
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Hmm, BandsWidget does not seem to load in the |
danielhollas
changed the title
edan-bainglass
approved these changes
Jun 4, 2026
Member
edan-bainglass
left a comment
edan-bainglass
left a comment
There was a problem hiding this comment.
Less code is always nice 🙂 LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #733
Removes the old
BandsDataViewerthat's apparently not used by QeApp? That allows us to remove the bokeh dependency and unpin numpy to support numpy 2.xAccording to the migration guide, hopefully no code changes needed 🤞https://github.com/bokeh/bokeh/wiki/Migration-Guides#300