Get rid of pandas dependency#737
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #737 +/- ##
==========================================
+ Coverage 84.82% 84.88% +0.06%
==========================================
Files 18 18
Lines 3374 3388 +14
==========================================
+ Hits 2862 2876 +14
Misses 512 512
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
danielhollas
left a comment
There was a problem hiding this comment.
Thanks for doing this.
I am really not stoked about the hand-written HTML and CSS. Can we try to use the tabulate package? This is a dependency that is used heavily in aiida-core and supports html output so should hopefully be easy to try out.
We can, but should we block this PR because of that? It achieves one important thing: it removes a major pandas dependency. Tabulate or any other options can be a follow-up PR. |
|
Okay, I don't want to block work. Can you please create an issue for the follow-up? |
|
@yakutovicha could you post in the description an example of a table before/after this PR? 🙏 |
A small fix was required in e6e7b1b Here we go: after:
|
edan-bainglass
left a comment
There was a problem hiding this comment.
LGTM! Thanks @yakutovicha.
Unrelated note for the future, regardless of which tech stack we use, great if we can avoid 1000+ line files 😵 Maybe better if we follow:
viewers/
__init__.py
utils.py # helper functions
this_viewer.py
that_viewer.py
...
Just a thought 🙂
danielhollas
left a comment
There was a problem hiding this comment.
Perfect, thanks @yakutovicha!


fixes #591