Skip to content

Get rid of pandas dependency#737

Merged
yakutovicha merged 8 commits into
masterfrom
update/no-pandas-dependency
Jun 3, 2026
Merged

Get rid of pandas dependency#737
yakutovicha merged 8 commits into
masterfrom
update/no-pandas-dependency

Conversation

@yakutovicha
Copy link
Copy Markdown
Member

@yakutovicha yakutovicha commented Mar 16, 2026

fixes #591

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.88%. Comparing base (87dae20) to head (867e128).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #737      +/-   ##
==========================================
+ Coverage   84.82%   84.88%   +0.06%     
==========================================
  Files          18       18              
  Lines        3374     3388      +14     
==========================================
+ Hits         2862     2876      +14     
  Misses        512      512              
Flag Coverage Δ
python-3.12 84.85% <100.00%> (+0.06%) ⬆️
python-3.9 84.87% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@danielhollas danielhollas self-requested a review March 24, 2026 16:08
Copy link
Copy Markdown
Contributor

@danielhollas danielhollas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this.

I am really not stoked about the hand-written HTML and CSS. Can we try to use the tabulate package? This is a dependency that is used heavily in aiida-core and supports html output so should hopefully be easy to try out.

@yakutovicha
Copy link
Copy Markdown
Member Author

I am really not stoked about the hand-written HTML and CSS. Can we try to use the tabulate package? This is a dependency that is used heavily in aiida-core and supports html output so should hopefully be easy to try out.

We can, but should we block this PR because of that? It achieves one important thing: it removes a major pandas dependency. Tabulate or any other options can be a follow-up PR.

@danielhollas
Copy link
Copy Markdown
Contributor

Okay, I don't want to block work. Can you please create an issue for the follow-up?
I think @edan-bainglass is a better reviewer for this since he already looked at the the aiidalab-home PR.

@edan-bainglass
Copy link
Copy Markdown
Member

@yakutovicha could you post in the description an example of a table before/after this PR? 🙏

@yakutovicha
Copy link
Copy Markdown
Member Author

@yakutovicha could you post in the description an example of a table before/after this PR? 🙏

A small fix was required in e6e7b1b

Here we go:

before:
image

after:

image

Copy link
Copy Markdown
Member

@edan-bainglass edan-bainglass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @yakutovicha.

Unrelated note for the future, regardless of which tech stack we use, great if we can avoid 1000+ line files 😵 Maybe better if we follow:

viewers/
    __init__.py
    utils.py  # helper functions
    this_viewer.py
    that_viewer.py
    ...

Just a thought 🙂

Copy link
Copy Markdown
Contributor

@danielhollas danielhollas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks @yakutovicha!

@yakutovicha yakutovicha merged commit 4676c32 into master Jun 3, 2026
9 checks passed
@yakutovicha yakutovicha deleted the update/no-pandas-dependency branch June 3, 2026 17:15
@danielhollas danielhollas added the dependencies Pull requests that update a dependency file label Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove pandas dependency

3 participants