Skip to content

Run selenium tests on python 3.12 nbclassic image#749

Merged
danielhollas merged 2 commits into
aiidalab:masterfrom
danielhollas:test-python3.12-image
Jun 4, 2026
Merged

Run selenium tests on python 3.12 nbclassic image#749
danielhollas merged 2 commits into
aiidalab:masterfrom
danielhollas:test-python3.12-image

Conversation

@danielhollas
Copy link
Copy Markdown
Contributor

@danielhollas danielhollas commented May 19, 2026

This PR is meant to test the upcoming nbclassic based python 3.12 image which is being prepared in aiidalab/aiidalab-docker-stack#479. Not meant to be merged.

EDIT: 3.12 image now has the edge tag so this can be merged.

@danielhollas danielhollas changed the title WIP: Run selenium tests on python 3.12 nbclassic image Run selenium tests on python 3.12 nbclassic image May 19, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.06%. Comparing base (d284e29) to head (3890486).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #749   +/-   ##
=======================================
  Coverage   85.06%   85.06%           
=======================================
  Files          18       18           
  Lines        3388     3388           
=======================================
  Hits         2882     2882           
  Misses        506      506           
Flag Coverage Δ
python-3.12 85.03% <ø> (ø)
python-3.9 85.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@danielhollas danielhollas force-pushed the test-python3.12-image branch from 3d7bdb3 to 3890486 Compare June 3, 2026 17:49
@danielhollas danielhollas marked this pull request as ready for review June 3, 2026 17:49
Copy link
Copy Markdown
Member

@edan-bainglass edan-bainglass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@danielhollas danielhollas merged commit 668b1e1 into aiidalab:master Jun 4, 2026
9 checks passed
@danielhollas danielhollas deleted the test-python3.12-image branch June 4, 2026 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants