Skip to content

Make StructureUploadWidget resilient towards invalid files#756

Merged
danielhollas merged 3 commits into
aiidalab:masterfrom
danielhollas:structure-upload-resilience
Jun 3, 2026
Merged

Make StructureUploadWidget resilient towards invalid files#756
danielhollas merged 3 commits into
aiidalab:masterfrom
danielhollas:structure-upload-resilience

Conversation

@danielhollas
Copy link
Copy Markdown
Contributor

Fixes #755

@danielhollas danielhollas requested a review from yakutovicha June 1, 2026 10:44
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 1, 2026

Codecov Report

❌ Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.06%. Comparing base (4676c32) to head (2870a7f).

Files with missing lines Patch % Lines
aiidalab_widgets_base/utils/__init__.py 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #756      +/-   ##
==========================================
+ Coverage   84.88%   85.06%   +0.17%     
==========================================
  Files          18       18              
  Lines        3388     3388              
==========================================
+ Hits         2876     2882       +6     
+ Misses        512      506       -6     
Flag Coverage Δ
python-3.12 85.03% <80.00%> (+0.17%) ⬆️
python-3.9 85.05% <80.00%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@danielhollas danielhollas added the bug Something isn't working label Jun 1, 2026
Copy link
Copy Markdown
Member

@yakutovicha yakutovicha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

little question

Comment thread aiidalab_widgets_base/structures.py
@danielhollas danielhollas requested a review from yakutovicha June 3, 2026 10:01
@danielhollas danielhollas merged commit d284e29 into aiidalab:master Jun 3, 2026
9 checks passed
@danielhollas danielhollas deleted the structure-upload-resilience branch June 3, 2026 17:38
danielhollas added a commit to danielhollas/aiidalab-widgets-base that referenced this pull request Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

StructureUploadWidget is not resilient towards invalid files

2 participants