-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Replace deprecated asyncio.iscoroutinefunction
with its counterpart from inspect
#10634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace deprecated asyncio.iscoroutinefunction
with its counterpart from inspect
#10634
Conversation
`asyncio.iscoroutinefunction` was deprecated in python/cpython#122875.
asyncio.iscoroutinefunction
with its counterpart from inspect
asyncio.iscoroutinefunction
with its counterpart from inspect
CodSpeed Performance ReportMerging #10634 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #10634 +/- ##
=======================================
Coverage 98.71% 98.71%
=======================================
Files 125 125
Lines 37368 37370 +2
Branches 2064 2064
=======================================
+ Hits 36886 36888 +2
Misses 335 335
Partials 147 147
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Co-authored-by: Sam Bull <[email protected]>
for more information, see https://pre-commit.ci
Backport to 3.11: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 77ad7d7 on top of patchback/backports/3.11/77ad7d7ea173eda1306297d275b2d5f7348f9f60/pr-10634 Backporting merged PR #10634 into master
🤖 @patchback |
Backport to 3.12: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 77ad7d7 on top of patchback/backports/3.12/77ad7d7ea173eda1306297d275b2d5f7348f9f60/pr-10634 Backporting merged PR #10634 into master
🤖 @patchback |
If you could handle those backports, that'd be great. |
… from `inspect` (aio-libs#10634) (cherry picked from commit 77ad7d7)
… from `inspect` (aio-libs#10634) (cherry picked from commit 77ad7d7)
… from `inspect` (aio-libs#10634) (cherry picked from commit 77ad7d7)
… from `inspect` (aio-libs#10634) (cherry picked from commit 77ad7d7)
… from `inspect` (aio-libs#10634) (cherry picked from commit 77ad7d7)
What do these changes do?
Replace
asyncio.iscoroutinefunction
withinspect.iscoroutinefunction
asyncio.iscoroutinefunction
was deprecated in python/cpython#122875.Are there changes in behavior for the user?
No.
Is it a substantial burden for the maintainers to support this?
No.
Related issue number
None.
Checklist
CONTRIBUTORS.txt
CHANGES/
foldername it
<issue_or_pr_num>.<type>.rst
(e.g.588.bugfix.rst
)if you don't have an issue number, change it to the pull request
number after creating the PR
.bugfix
: A bug fix for something the maintainers deemed animproper undesired behavior that got corrected to match
pre-agreed expectations.
.feature
: A new behavior, public APIs. That sort of stuff..deprecation
: A declaration of future API removals and breakingchanges in behavior.
.breaking
: When something public is removed in a breaking way.Could be deprecated in an earlier release.
.doc
: Notable updates to the documentation structure or buildprocess.
.packaging
: Notes for downstreams about unobvious side effectsand tooling. Changes in the test invocation considerations and
runtime assumptions.
.contrib
: Stuff that affects the contributor experience. e.g.Running tests, building the docs, setting up the development
environment.
.misc
: Changes that are hard to assign to any of the abovecategories.
Make sure to use full sentences with correct case and punctuation,
for example:
Use the past tense or the present tense a non-imperative mood,
referring to what's changed compared to the last released version
of this project.