parameterize mysql_address in tests, allow passing one or more addresses via pytest args #693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #693 +/- ##
=======================================
Coverage 85.70% 85.70%
=======================================
Files 12 12
Lines 2085 2085
Branches 336 336
=======================================
Hits 1787 1787
Misses 228 228
Partials 70 70
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
…ses via pytest args
Nothing4You
force-pushed
the
tests-mysql-address-arg
branch
from
2e9bd63 to
c12161e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Second set of changes split from #686.
This allows passing a mysql address via pytest argument, preparing for being able to test more databases/database connections in the same pytest run.
An unfortunate side effect of this currently is that pytest now no longer groups the tests with different event loop implementations.
I haven't dug into pytest too much yet to figure out if that can be solved, but this is mostly just a cosmetic/convenience difference.