Skip to content
Draft
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 24 additions & 3 deletions async_lru/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ class _CacheParameters(TypedDict):
class _CacheItem(Generic[_R]):
fut: "asyncio.Future[_R]"
later_call: Optional[asyncio.Handle]
waiters: int

def cancel(self) -> None:
if self.later_call is not None:
Expand Down Expand Up @@ -205,7 +206,13 @@ async def __call__(self, /, *fn_args: Any, **fn_kwargs: Any) -> _R:
if cache_item is not None:
self._cache_hit(key)
if not cache_item.fut.done():
return await asyncio.shield(cache_item.fut)
cache_item.waiters += 1
try:
return await asyncio.shield(cache_item.fut)
except CancelledError:
_handle_cancelled_error(cache_item, task)
finally:
cache_item.waiters -= 1

return cache_item.fut.result()

Expand All @@ -215,14 +222,21 @@ async def __call__(self, /, *fn_args: Any, **fn_kwargs: Any) -> _R:
self.__tasks.add(task)
task.add_done_callback(partial(self._task_done_callback, fut, key))

self.__cache[key] = _CacheItem(fut, None)
cache_item = _CacheItem(fut, None, 1)
self.__cache[key] = cache_item

if self.__maxsize is not None and len(self.__cache) > self.__maxsize:
dropped_key, cache_item = self.__cache.popitem(last=False)
cache_item.cancel()

self._cache_miss(key)
return await asyncio.shield(fut)

try:
return await asyncio.shield(fut)
except CancelledError:
_handle_cancelled_error(cache_item, task)
finally:
cache_item.waiters -= 1

def __get__(
self, instance: _T, owner: Optional[Type[_T]]
Expand All @@ -233,6 +247,13 @@ def __get__(
return _LRUCacheWrapperInstanceMethod(self, instance)


def _handle_cancelled_error(cache_item: _CacheItem, task: asyncio.Task[Any]) -> None:
if cache_item.waiters == 1 and not task.done():
task.cancel()
cache_item.cancel()
self.__cache.pop(key)


@final
class _LRUCacheWrapperInstanceMethod(Generic[_R, _T]):
def __init__(
Expand Down