-
-
Notifications
You must be signed in to change notification settings - Fork 112
add Python 3.14 CI #1235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Python 3.14 CI #1235
Conversation
CodSpeed Performance ReportMerging #1235 will not alter performanceComparing Summary
|
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1235 +/- ##
==========================================
- Coverage 99.85% 99.85% -0.01%
==========================================
Files 26 26
Lines 3510 3507 -3
Branches 252 252
==========================================
- Hits 3505 3502 -3
Misses 3 3
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought something was altered from the tests I've added but this doesn't seem to be the case, glad this has now been added in this should be good for stress-testing the 3.14 update.
@kumaraditya303 I did not notice this earlier but it seems some tests are failing for some reason let me go in and see if I can suggest any changes. The others are on a tighter schedule than me apparently. |
The failing tests are leak tests, it is likely that it is because of gc changes in 3.14 or just higher memory usage on 3.14 interpreter though I haven't looked at it closely. |
Makes sense. I mainly implemented the newer memory-leak test to prevent newer memory leak issues in the future since there have been several incidents in MultiDict's history of this happening repetitively. I am surprised it's not related to that one and only istr. When |
for more information, see https://pre-commit.ci
@kumaraditya303 Great job, I'll be sure to contact one of the contributors over on matrix If I don't see any activity here in the next couple days. |
Thanks I have updated the tests for CPython 3.14, specifically these two changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kumaraditya303
What do these changes do?
Are there changes in behavior for the user?
Related issue number
Checklist