numberFormat callback to format numbers#122
Draft
JiLiZART wants to merge 2 commits intoairbnb:masterfrom
JiLiZART:format-numbers
Draft
numberFormat callback to format numbers#122JiLiZART wants to merge 2 commits intoairbnb:masterfrom JiLiZART:format-numbers
JiLiZART wants to merge 2 commits intoairbnb:masterfrom
JiLiZART:format-numbers
Conversation
Author
Collaborator
|
@JiLiZART please never open a duplicate PR; now I have to keep two of them in sync, or else there will permanently be a second PR ref cluttering the repo. The reason #72 isn't merged isn't because it hasn't been updated, it's because we're not clear on even if this should be merged, let alone what it should look like. |
ljharb
requested changes
Aug 11, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#72 didn't update since 2016.
I recreated this PR with some fixes, to pass checks