fix(source-clickhouse-strict-encrypt): remove conflicting JDBC driver version causing HTTP 500 on schema refresh#74889
Conversation
… version The recent JDBC driver upgrade in source-clickhouse (PR #72395) updated clickhouse-jdbc from 0.3.2-patch10 to 0.9.5, but source-clickhouse-strict-encrypt still pinned the old 0.3.2-patch10 version directly while also pulling in 0.9.5 transitively via the source-clickhouse project dependency. These two driver versions are fundamentally different packages (ru.yandex.clickhouse vs com.clickhouse), causing a classpath conflict that crashes the discover (schema refresh) operation on Airbyte Cloud with an HTTP 500 error. Fix: Remove the explicit old driver dependency from source-clickhouse-strict-encrypt so it uses the 0.9.5 driver from source-clickhouse transitively. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Note 📝 PR Converted to Draft More info...Thank you for creating this PR. As a policy to protect our engineers' time, Airbyte requires all PRs to be created first in draft status. Your PR has been automatically converted to draft status in respect for this policy. As soon as your PR is ready for formal review, you can proceed to convert the PR to "ready for review" status by clicking the "Ready for review" button at the bottom of the PR page. To skip draft status in future PRs, please include |
|
|
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksPR Slash CommandsAirbyte Maintainers (that's you!) can execute the following slash commands on your PR:
📚 Show Repo GuidanceHelpful Resources
|
|
Note Detected that there are differences in the Gradle dependencies. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
|
|
↪️ Triggering Reason: Draft PR with CI passing. Fix removes conflicting JDBC driver version causing HTTP 500 on schema refresh for ClickHouse Cloud users. |
|
Fix Validation EvidenceOutcome: Could not Run Tests (live connection testing blocked on approval; regression SPEC passed) Evidence SummaryRegression tests were run against the pre-release image ( Live connection testing was blocked: approval for pinning customer connections was requested via Slack to Rajath sinha (@rajathsinhaa) but no response was received within the session window. No internal Airbyte connections use this connector, so all test candidates require approval. Next Steps
Connector & PR DetailsConnector: Evidence PlanProving Criteria
Disproving Criteria
Cases Attempted
Pre-flight Checks
Detailed Evidence Log
Note: Connection IDs and detailed logs are recorded in the linked private issue. |
|
3 participants
What
Fixes HTTP 500 errors on schema refresh (discover) for ClickHouse source connections on Airbyte Cloud.
PR #72395 upgraded the ClickHouse JDBC driver in
source-clickhousefrom0.3.2-patch10to0.9.5, but did not remove the old explicit dependency insource-clickhouse-strict-encrypt. Sincesource-clickhouse-strict-encryptis what Airbyte Cloud deploys (persource-clickhouse/metadata.yamlregistry override), this classpath conflict affects all Cloud users of this connector.The
0.3.xdriver (ru.yandex.clickhouse) and0.9.xdriver (com.clickhouse) are fundamentally different packages. Having both on the classpath causes the discover operation to crash.How
Removed the explicit
clickhouse-jdbc:0.3.2-patch10:alldependency fromsource-clickhouse-strict-encrypt/build.gradle. The connector already getsclickhouse-jdbc:0.9.5transitively viaimplementation project(':airbyte-integrations:connectors:source-clickhouse').Review guide
airbyte-integrations/connectors/source-clickhouse-strict-encrypt/build.gradle— the only changed file. Two lines removed.Key things to verify:
clickhouse-jdbc:0.9.5on the classpath after this change (no other transitive conflicts)267f5ad2954). The 0.9.5 upgrade in feat(source-clickhouse): upgrade JDBC driver to 0.9.5 with custom type mapping #72395 addedClickHouseSourceOperationsto handle type mapping differences, but the strict-encrypt variant was not validated at that timeUser Impact
ClickHouse source connections on Airbyte Cloud should be able to refresh schemas (discover) without HTTP 500 errors. This is currently a complete blocker for affected users.
Can this PR be safely reverted and rolled back?
Link to Devin session: https://app.devin.ai/sessions/37f1533976c6489abc5a3eacafa59607
Requested by: Rajath sinha (@rajathsinhaa)