-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add streamlit readme #168
Add streamlit readme #168
Conversation
consistency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a suggestion concerning streamlit installation
Very nicee!!! @oke-aditya can you clean the streamlit code before we add this to the readme? Currently there are a lot of commented code lines, and some general refactor could be done as well, for instance, you have very helpful comments explaining what is the purpose of the function, those should be docstrings. Keep in mind that this is going to be our front page for deployment, so the code needs to be as clean as possible |
Yes I will clean it up. Some final touch up is needed. |
|
Alright, much better! But there are still some things
|
Also, are you doing imagenet normalization? You can use |
Let me clear the code duplication issue. This file cannot have relative imports etc. So I need to paste all the code in src into here. So ignore the duplication with app and others. |
@oke-aditya, I think we need to have just one single I just tested the 2 options, they both work: So one code base, let's keep it DRY 😃 . Option 1: Local Option 2: Local Some changes: I think this should be changed in In line 217, In line 258: add ? to in line 307: Replace You by Your In Replace To run click on Run app in sidebar. by To run the app, select Run app from the combo box on the sidebar (on the left). |
ok. I will make the suggestd changes. If I keep only the app.py. Should I keep files such as src/utils.py, src/model.py etc ? |
I think It would be better to remove them, and in the Something as simple as this (or similar):
Great Job! |
Ok. I will remove that too from master branch. Instead have master branch only with app.py from where users can run. |
Done. I have updated the master branch. It has only app.py. I tested it. It is working. Also, we on dev branch the modularized code which a user might need. |
Adds streamlit to readme.
Please check if the link works.