-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fasterrcnn example #80
Conversation
Check out this pull request on Review Jupyter notebook visual diffs & provide feedback on notebooks. Powered by ReviewNB |
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
==========================================
- Coverage 56.00% 51.39% -4.62%
==========================================
Files 55 60 +5
Lines 1714 1827 +113
==========================================
- Hits 960 939 -21
- Misses 754 888 +134
Continue to review full report at Codecov.
|
Thanks for the PR! You should use ReviewNB for checking the code suggestions, it should show nice in notebook changes. |
There is a lot of overlap between this tutorial and this one. I do like the part while you over the different models we can use thought. I have two suggestions: 1Merge the two tutorials into one. But keep in mind that this is probably going to be the first tutorial beginners see, so try not to overwhelm them with information 2Transform this into a advanced/extended tutorial, in this case you can even tell how stuff is happening in the inside, going really into detail, don't spare words. I personally like more suggestion 2, which I think is going to be very complementary to the tutorials we already have and will facilitate a lot the lives of people wanting to get involved with the library. But it's also a lot more work... well, your call at the end 😆 |
Personally Even I felt I should do 2nd thing. We can have 2 tutorials, first one as a QuickStart. And 2nd an in depth guide for this. |
The code block does not look good on ReviewNB. But locally it is looking like a code block
|
@ai-fast-track can we get your input? I feel like there is a lot of overlaps in the tutorials right now, between this one, wheat and parser. Should we avoid overlap or is it a good thing to have multiple tutorials with different levels of details? |
Helps issue #39 |
@ai-fast-track can you please have a look ? |
@lgvaz @oke-aditya, I think we should add this notebook even if there is some overlap with wheat.ipynb. The latter can be used as quick showcase and highlighted (by exposing its source code) in the README For this tutorial, I think we should use one of the toy (small) dataset that we discussed about during the last meeting. A dataset that uses the COCO format. That way, this notebook will be different (COCO parser) from the wheat notebook (custom parser), and we can easily and quickly run it in Colab! |
@ai-fast-track Suggestions are made. Can you please have another look? |
Please check the tutorial.
If more details about Faster RCNN and its hyperparameters is required, please tell me I will add it.
Also if some theory about this model is required. Will add that as well.