Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for hashtag searching #57

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add support for hashtag searching #57

wants to merge 2 commits into from

Conversation

toolstack
Copy link
Contributor

Check the search term against category/tags and return them if they are case insensitively matched.

akirk
akirk requested changes Jan 10, 2024
View reviewed changes
Copy link
Owner

@akirk akirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This is a good improvement, I'd just rather use the search parameter over looping over the categories and tags.

@toolstack toolstack force-pushed the hashtag-search branch 4 times, most recently from 3383c31 to 8c81562 Compare January 11, 2024 02:01
@toolstack
Add hashtag search support.
7a5cf21 
And check for empty queries so we don't waste time with them.
@toolstack
Copy link
Contributor Author

@akirk I've rebased this for the latest updates to main, I think it along with #50, #54, and #56 as ready to go.

I'm reworking the other three to see if I can get them using taxonomies and should have something in a couple of days for them.

Drivingralle added a commit that referenced this pull request Mar 18, 2024
@Drivingralle
copy changes from PR #57 to kick off hashtag search
de84fc9
Drivingralle added a commit that referenced this pull request Mar 18, 2024
@Drivingralle
copy improvments from PR #57
2190ad4
@Drivingralle Drivingralle mentioned this pull request Mar 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akirk akirk akirk requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@toolstack @akirk