-
Notifications
You must be signed in to change notification settings - Fork 379
chore: bump kafka-clients to 4.1.0 #1843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
build.sbt
Outdated
val kafkaVersion = "3.7.1" | ||
val KafkaVersionForDocs = "37" | ||
val kafkaVersion = "4.0.0" | ||
val KafkaVersionForDocs = "40" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to bump test containers because client 4.0.0 also works with old brokers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test containers is still the version we have in main
, isn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I misread your questions, which was more of a "if it should be bumped or not". I think not, since it works?
Let's hold this off if bumping to 3.9 is enough for now. |
I removed the Scala Steward restriction, should be OK to move along on the 4.x line. |
The Mockito based tests need a review. |
|
Upgrade the Kafka client library to 4.1.0