Skip to content

Conversation

sebastian-alfers
Copy link
Contributor

@sebastian-alfers sebastian-alfers commented May 14, 2025

Upgrade the Kafka client library to 4.1.0

build.sbt Outdated
val kafkaVersion = "3.7.1"
val KafkaVersionForDocs = "37"
val kafkaVersion = "4.0.0"
val KafkaVersionForDocs = "40"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to bump test containers because client 4.0.0 also works with old brokers?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test containers is still the version we have in main, isn't it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I misread your questions, which was more of a "if it should be bumped or not". I think not, since it works?

@johanandren
Copy link
Contributor

Let's hold this off if bumping to 3.9 is enough for now.

@ennru ennru marked this pull request as draft August 1, 2025 06:38
@ennru
Copy link
Contributor

ennru commented Oct 3, 2025

I removed the Scala Steward restriction, should be OK to move along on the 4.x line.

@ennru ennru marked this pull request as ready for review October 3, 2025 12:49
@ennru ennru changed the title chore: bump kafka-clients to 4.0.0 chore: bump kafka-clients to 4.1.0 Oct 3, 2025
@ennru
Copy link
Contributor

ennru commented Oct 6, 2025

The Mockito based tests need a review.

@ennru
Copy link
Contributor

ennru commented Oct 15, 2025

Mockito is currently self-attaching to enable the inline-mock-maker. This will no longer work in future releases of the JDK. Please add Mockito as an agent to your build as described in Mockito's documentation: https://javadoc.io/doc/org.mockito/mockito-core/latest/org.mockito/org/mockito/Mockito.html#0.3
WARNING: A Java agent has been loaded dynamically (/home/runner/.cache/coursier/v1/https/repo1.maven.org/maven2/net/bytebuddy/byte-buddy-agent/1.17.7/byte-buddy-agent-1.17.7.jar)
WARNING: If a serviceability tool is in use, please run with -XX:+EnableDynamicAgentLoading to hide this warning
WARNING: If a serviceability tool is not in use, please run with -Djdk.instrument.traceUsage for more information
WARNING: Dynamic loading of agents will be disallowed by default in a future release
OpenJDK 64-Bit Server VM warning: Sharing is only supported for boot loader classes because bootstrap classpath has been appended

@ennru ennru requested a review from johanandren October 15, 2025 08:06
@johanandren johanandren merged commit 7a546a1 into main Oct 15, 2025
15 checks passed
@johanandren johanandren deleted the kafka-4.0 branch October 15, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants