FlowWithContext #83
Merged
FlowWithContext #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
|
All right, this PR is finally ready for review. And this is going to be last not-transactional stage implemented for this project. Cool :) |
This was referenced Oct 29, 2019
Merged
|
Thanks @IgorFedchenko - I'll review all three of these today. |
|
@IgorFedchenko looks like a |
| { | ||
| public static class FlowExtensions | ||
| { | ||
| // TODO: Move this to Akka.Streams core library |
There was a problem hiding this comment.
Can you open a PR to do this?
There was a problem hiding this comment.
@Aaronontheweb Added PR: akkadotnet/akka.net#4023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a part of issue #36 , this PR is going to implement
FlowWithContext.This flow usually used with any of the sources, that support context, to produce new records to kafka while keeping context info.
Besides the work on this new flow,
FlexiFlowis implemented as a core flow of producer flows and sinks. All other sinks/flows (likeCommuttableSinkorPlainSink) are based onFlexiFlow. This includes support of publishing several types of messages (SingleMessage,MultiMessage, and pseudo-publishedPassThroughMessage) instead of singleMessageAndMetamessage (which was almost the same asSingleMessagebut without context passing support).So, after this PR merged publishers code base is going to me much closed to alpakka implementation. That will help adding features and support existing ones.
P.S. PR is in draft state because test is still failing - some issues with graph execution task awaiting.