Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fsharp console template #407

Merged

Conversation

richardjharding
Copy link
Contributor

@richardjharding richardjharding commented Feb 18, 2025

Changes

Adds an F# version of the AkkaConsole template see #399

Checklist

For significant changes, please ensure that the following have been completed (delete if not relevant):

Latest dev Benchmarks

Include data from the relevant benchmark prior to this change here.

This PR's Benchmarks

Include data from after this change here.

Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as far as I can tell but the real boss is going to be our CI/CD system

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -101,6 +101,9 @@ $binlog = [IO.Path]::GetFullPath([IO.Path]::Combine($pwd, "..", "binlog", "test.
Create-And-Build "akka.console" "AkkaConsole" "C#" "f" "net9.0" $binlog
Create-And-Build "akka.console" "AkkaConsole" "C#" "f" "net8.0" $binlog

Create-And-Build "akka.console" "AkkaConsole" "F#" "f" "net9.0" $binlog
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - we'll see what CI/CD says

@Aaronontheweb
Copy link
Member

Woohoo!

image

@Aaronontheweb
Copy link
Member

image - we are good to go! I'll prepare a new release

@Aaronontheweb Aaronontheweb added this pull request to the merge queue Feb 19, 2025
Merged via the queue into akkadotnet:dev with commit 707acc5 Feb 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants