Skip to content

Comments

Adding get and create DP docs [SA-20990] (develop)#208

Merged
armatronic merged 4 commits intodevelopfrom
feature-develop/SA-20990
Feb 5, 2026
Merged

Adding get and create DP docs [SA-20990] (develop)#208
armatronic merged 4 commits intodevelopfrom
feature-develop/SA-20990

Conversation

@tchiang0530
Copy link
Contributor

No description provided.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 21, 2026

Deploying schoolbox-api-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 496924d
Status: ✅  Deploy successful!
Preview URL: https://7729f3b1.schoolbox-api-docs.pages.dev
Branch Preview URL: https://feature-develop-sa-20990.schoolbox-api-docs.pages.dev

View logs

@tchiang0530 tchiang0530 changed the title Adding get and create DP docs [SA-20990] Adding get and create DP docs [SA-20990] (develop) Jan 21, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds OpenAPI documentation for differentiation profile endpoints, introducing GET, POST, and PUT operations for managing student differentiation profiles.

Changes:

  • Added new differentiation profile API endpoints for retrieving, creating, and updating profiles for students
  • Defined the differentiation profile schema with student information, adjustment categories/levels, and various profile fields
  • Added corresponding request body and response specifications

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 10 comments.

Show a summary per file
File Description
openapi/paths/differentiation-profiles@student@{id}.yaml Defines GET, POST, and PUT operations for student differentiation profiles
openapi/openapi.yaml Adds differentiation tag and path reference to the main OpenAPI specification
openapi/components/schemas/differentiation.yaml Defines the complete differentiation profile schema with all properties
openapi/components/responses/differentiationProfile.yaml Defines the response format for differentiation profile operations
openapi/components/requestBodies/differentiation.yaml Defines the request body schema for creating/updating differentiation profiles

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +13 to +14
parameters:
- $ref: ../components/parameters/id.yaml
Copy link

Copilot AI Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parameters section should be placed at the end of the file, after all operation definitions (get, post, put), not in the middle. This is the convention followed throughout the codebase. See examples in user@{id}.yaml (line 53), user@{id}@groupMembership@{groupId}.yaml (line 67), and calendar@event@{id}@move.yaml (line 1-2).

Copilot uses AI. Check for mistakes.
@armatronic armatronic merged commit 7ed0bac into develop Feb 5, 2026
7 checks passed
@armatronic armatronic deleted the feature-develop/SA-20990 branch February 5, 2026 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants