Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agg builder blog post #2

Draft
wants to merge 6 commits into
base: v2.x
Choose a base branch
from
Draft

Conversation

alcaeus
Copy link
Owner

@alcaeus alcaeus commented Oct 23, 2024

Please ignore the test files - only article.md needs review.

Comment on lines 710 to 713
the builder and feel what it's like. To top it all off, we could add this code
to the server documentation, similar to how we add other language-specific code
snippets. We're not quite there yet, but we'd love to include this in the
documentation.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ultimately, we love to add this builder code to the server documentation, similar to how we add other language-specific code snippets, but we're not quite there yet.

See if that reads better. I don't think this idea warrants more than a single sentence.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, much better 👍

@alcaeus alcaeus requested a review from jmikola October 24, 2024 11:30
Copy link

@jmikola jmikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more optional suggestions. Take what you like.

underscore would break alphabetical sorting in code completion.

A less-than-serious approach was to use emojis, which I learned was valid in
PHP:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to be especially evil: https://en.wikipedia.org/wiki/Zero-width_space

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants