-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Agg builder blog post #2
base: v2.x
Are you sure you want to change the base?
Conversation
tests/AggregationBlogPost/article.md
Outdated
the builder and feel what it's like. To top it all off, we could add this code | ||
to the server documentation, similar to how we add other language-specific code | ||
snippets. We're not quite there yet, but we'd love to include this in the | ||
documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ultimately, we love to add this builder code to the server documentation, similar to how we add other language-specific code snippets, but we're not quite there yet.
See if that reads better. I don't think this idea warrants more than a single sentence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, much better 👍
Co-authored-by: Jeremy Mikola <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more optional suggestions. Take what you like.
underscore would break alphabetical sorting in code completion. | ||
|
||
A less-than-serious approach was to use emojis, which I learned was valid in | ||
PHP: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to be especially evil: https://en.wikipedia.org/wiki/Zero-width_space
Co-authored-by: Jeremy Mikola <[email protected]>
Please ignore the test files - only article.md needs review.