Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cargo: (universally supported) instead of cargo:: (1.80+ only) syntax for rustc-check-cfg #581

Merged
merged 3 commits into from
Sep 30, 2024

Conversation

nabijaczleweli
Copy link
Contributor

Ref: #575
Closes #576
Closes nabijaczleweli/cargo-update#277
Supplants #577

@nabijaczleweli
Copy link
Contributor Author

CI failure unrelated :v

@alexcrichton
Copy link
Owner

As-is the case with #577, can you add CI here for the version that you're interested in?

@nabijaczleweli
Copy link
Contributor Author

nabijaczleweli commented Sep 30, 2024

Added rustc 1.75 (Ubuntu LTS 24.04). 1.63 (Debian Bookworm) would also be nice but that pre-dates fetchable registries, so that's an excessive burden I think.

The x86_64-musl failure seems unrelated (curl openssl.tar.gz | tar -xz fails to decompress as gzip?).

@alexcrichton
Copy link
Owner

Thanks! I think the CI failure is the need to update this line too?

@nabijaczleweli
Copy link
Contributor Author

Survey says: no (but I did update that too, thanks).

I wanna say that if you trigger a build on trunk it will happen too? This smells like a mirror issue (if I repeat the failing curl locally I get a valid gzip stream).

@nabijaczleweli
Copy link
Contributor Author

Actually no, I wgetted it 💀 curl https://www.openssl.org/source/old/1.0.2/openssl-1.0.2g.tar.gz | tar tzf - does fail.

perl curl -v this just wants -L:

< HTTP/2 301
< content-type: text/html
< location: https://github.com/openssl/openssl/releases/download/OpenSSL_1_0_2g/openssl-1.0.2g.tar.gz
< x-cloud-trace-context: 6bbbe5a1d38426fd969f050d7e9dd009
< date: Mon, 30 Sep 2024 18:14:55 GMT
< server: Google Frontend
< content-length: 169
< via: 1.1 google
< strict-transport-security: max-age=31536000; includeSubDomains; preload

@nabijaczleweli
Copy link
Contributor Author

yup, that fixed it. and the 1.75 job works too

@alexcrichton alexcrichton merged commit 37bc337 into alexcrichton:main Sep 30, 2024
14 checks passed
alexcrichton added a commit that referenced this pull request Sep 30, 2024
Making a release for #581
alexcrichton added a commit that referenced this pull request Sep 30, 2024
Making a release for #581
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants