entry: Use strip_prefix
#329
Conversation
Minor drive by code cleanup; `strip_prefix` is just more readable and more bug-resistant than manually doing it with `starts_with` combined with slicing.
|
@alexcrichton This crate is currently very important to some software I maintain; I'd probably be able to act as a 20%-time co-maintainer. Maybe what we could do is find a few other interested parties, and switch things so that merging a PR requires 2 approving reviews? Looking at the outstanding PRs there are some other people in the list that I'd trust to be co-maintainers too, e.g. @sunshowers. |
|
Thank you for the offer! I would be happy to have help maintaining this crate as I think I clearly can't offer the support it needs. If y'all would like would you be ok if I sort of "phased y'all in" over time? For example would you be ok reviewing PRs and then pinging me when it's ready to merge? After a few PRs I can give y'all write access to merge PRs yourselves and then you'd only need to ping me for releases. After a release or two perhaps I could invite y'all to crates.io to publish without me as well. |
Yes definitely. I tried to figure out a way to coerce the Github search to list "PRs reviewed and approved by @cgwalters" (or an arbitrary set of other users) but it only does "PRs that were approved" which isn't the same thing. Anyways here's my list of PRs that I believe are good:
What you may also find useful as a reference is PRs for which I didn't approve or requested changes to see if we agree on architecture: |
|
All looks great, thank you again for your help here, it's very much appreciated! Feel free to ping me for merging those PRs when they're ready and I'll do a final once-over, your comments look good to me. It's also been awhile since a release has been made, if you're up for it mind opening a PR with a version bump? I can publish to crates.io after when it's ready. |
Minor drive by code cleanup; `strip_prefix` is just more readable and more bug-resistant than manually doing it with `starts_with` combined with slicing. (cherry picked from commit 2224f6e)
Minor drive by code cleanup;
strip_prefixis just more readable and more bug-resistant than manually doing it withstarts_withcombined with slicing.