Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builder: Add a set_rdev() convenience #377

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cgwalters
Copy link
Collaborator

Commonly one may be building tar archives from the filesystem in a custom way, or operating on a translation of a non-tar format which uses rdev, not split major/minor.

Today one needs to replicate the nontrivial bit manipulations to split the device; but since we have that code anyways in our own "build from filesystem" code, let's just add it as a public API.

Commonly one may be building tar archives from the filesystem
in a custom way, or operating on a translation of a non-tar
format which uses rdev, not split major/minor.

Today one needs to replicate the nontrivial bit manipulations
to split the device; but since we have that code anyways in
our own "build from filesystem" code, let's just add it as a public
API.

Signed-off-by: Colin Walters <[email protected]>
@cgwalters
Copy link
Collaborator Author

Hum right, dev_t here is platform dependent. Fun. OK I switched to libc::dev_t in the public API.

@alexcrichton
Copy link
Owner

Took me awhile to get here, but seems reasonable to me! I think there's still some compilation issues though?

@cgwalters cgwalters marked this pull request as draft September 20, 2024 18:16
@cgwalters
Copy link
Collaborator Author

Yeah this needs some more work; not at all urgent. I'll unmark it as draft when ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants