add from_file to Tokenizer c++ binding #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. add "crt-static" flag to ensure all libraries are built with static crt library. 2. add staticlib target in addition to cdylib target.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @alexeyr,
Thanks for your work on c++ binding. It is really helpful and useful to C++ projects.
Based on your work and with my limited knowledge to Rust, I exposed the
from_filefunction to C++, which seems to work in unit tests. I'd merge this change to your PR just to be helpful to others too. Could you help me review this and see if the code is correct? Thanks!