-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/mage 725 - category versioning #1434
Open
cammonro
wants to merge
52
commits into
develop
Choose a base branch
from
feature/MAGE-725
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update module version
release/3.11.0
Updated changelog
…nt premature truncation of available categories while determining root path
…e scope behaviors
… this scenario). This is instead handled separately by the move plugin.
…ry path data can become out of sync)
# Conflicts resolved: # Model/Indexer/CategoryObserver.php
# Conflicts resolved: # Block/Algolia.php
…iteria in attribute class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a work in progress - and there are missing use cases I'm still working through - but this does achieve a bridge between the state when product category assignments are made in Magento but have not yet synced into the Algolia index.
This intermediary state normally is highly disruptive and causes category pages to break until all impacted products have fully synced.
The essence of this feature is to piggy back off of the new flattened
categoryPageId
format used for visual merchandising of categories. This pattern is used to generate hierarchies flattened as "snapshots" of possible category paths for a moment in time (before ever syncing to Algolia). The versioning is maintained in Magento (scoped by affected store) to generate filters for InstantSearch to preserve connectivity with the data as it is loaded asynchronously into Algolia.A sample of the change log may look as follows:
This feature also addresses the missing handling of category move operations in Magento which have not been captured to date without intervention through manual indexing.
Some key improvements that are still needed:
CategoryVersionLogger
needs to also handle the impact of changes to parent categories that can trickle down to products assigned to child categories.