MAGE-986 Configurable no-code redirects #1740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damcou
reviewed
Apr 28, 2025
cammonro
force-pushed
the
feat/MAGE-986-no-code-redirect-config
branch
from
f81a47b to
5fbac83
Compare
damcou
approved these changes
Apr 29, 2025
| $checked ? 'checked' : '' | ||
| ); | ||
| $html .= '<div class="form-content">'; | ||
| $html .= sprintf('<label>%s</label>',$label ?? $name); |
There was a problem hiding this comment.
Not mandatory, but maybe we would want the label to be clickable to check the related checkbox with a for property related to an id property on the input ? Feel free to ignore if you want to move on.
There was a problem hiding this comment.
This is a great idea and I neglected to do it. Thanks for raising it! Will amend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR provides configurability for the redirect features added for both Autocomplete and InstantSearch.
onSubmithandler was identified with the Autocomplete plugin so state was added to the Autocomplete UI component to track when redirects are retrieved on the product sourcenavigatorobject has been added toautocomplete.jsUI component to facilitate customization / overriding of URL navigation behaviors.ConfigHelperproblem by splitting out domain specific config helpers for both Autocomplete and InstantSearchSerializerservice for composability and to prevent circular dependencies between helpersResult
Autocomplete configuration
Redirect only on submit
Redirect with selectable menu item
Redirect with selectable menu item and matching hits
InstantSearch configuration
Redirect with selectable item
Unit tests
