Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(javascript): add support for private package publish #4106

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

the release script for js failed on the composition package, I assume it is because we went from a private to a public package with manual interventions

this pr updates the public script to support (in a non programmatically way) the private and alpha releases

@shortcuts shortcuts self-assigned this Nov 14, 2024
@shortcuts shortcuts requested a review from a team as a code owner November 14, 2024 16:52
@algolia-bot
Copy link
Collaborator

algolia-bot commented Nov 14, 2024

No code generated

If you believe code should've been generated, please, report the issue.

📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 985

Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, too bad there is no way to know based on the package.json

@shortcuts shortcuts merged commit b97a88b into main Nov 14, 2024
12 checks passed
@shortcuts shortcuts deleted the fix/private-package-support-javascript branch November 14, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants