feat(a11y): add aria-keyshortcuts to search button
#2365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvandercar-vt
requested review from
shortcuts and
francoischalifour
as code owners
👷 Deploy request for docsearch pending review.Visit the deploys page to approve it
|
bvandercar-vt
changed the title
aria-keyshortcuts to search button
| @@ -34,14 +34,17 @@ export const DocSearchButton = React.forwardRef<HTMLButtonElement, DocSearchButt | |||
| const [actionKeyReactsTo, actionKeyAltText, actionKeyChild] = | |||
| key === ACTION_KEY_DEFAULT | |||
| ? // eslint-disable-next-line react/jsx-key -- false flag | |||
| ([ACTION_KEY_DEFAULT, 'Ctrl', <ControlKeyIcon />] as const) | |||
| : (['Meta', 'Command', key] as const); | |||
| ([ACTION_KEY_DEFAULT, 'Control', <ControlKeyIcon />] as const) | |||
There was a problem hiding this comment.
do we need this change? Ctrl -> Control ?
and 'Meta', 'Command', key -> 'Meta', 'Meta', key
There was a problem hiding this comment.
Yes, Ctrl and Command aren't valid values for aria-keyshortcut: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-keyshortcuts
Control and Meta are.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-keyshortcuts