test(common): support per-flavor skips and normalize recommend snapshots#7030
Draft
aymeric-giraudet wants to merge 1 commit into
Draft
test(common): support per-flavor skips and normalize recommend snapshots#7030aymeric-giraudet wants to merge 1 commit into
aymeric-giraudet wants to merge 1 commit into
Conversation
Two small refactors to the shared widget test suites so the upcoming Vue ports don't have to skip whole describe blocks: - `filter-suggestions/options.ts` and `templates.tsx` now use `skippableTest` / `skippableDescribe` for the cases Vue can't reproduce 1:1 (sync connector throws Vue swallows, React/JS pass function-valued `templates`/`itemComponent`/`headerComponent`/ `emptyComponent` props). Types in `index.ts` no longer mark `vue` as `Record<string, never>` so Vue can receive real connector params, and every test case fills in a proper Vue params payload. - The recommendation widget suites (`related-products`, `trending-items`, `trending-facets`) now snapshot via `toMatchNormalizedInlineSnapshot(normalizeSnapshot, …)`, matching the existing `looking-similar` / `frequently-bought-together` pattern. Required because Vue 3 wraps native `Fragment`s with extra whitespace text nodes that the normalizer already strips. No widget changes; React and JavaScript flavors keep their existing behavior.
This was referenced May 13, 2026
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 2 |
TIP This summary will be updated as you push new changes.
More templates
algoliasearch-helper
instantsearch-ui-components
instantsearch.css
instantsearch.js
react-instantsearch
react-instantsearch-core
react-instantsearch-nextjs
react-instantsearch-router-nextjs
vue-instantsearch
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on top of #7029.
Summary
Test infrastructure changes needed before the Vue recommendation/FilterSuggestions ports can land. No widget changes.
Test plan
Next in the stack: React widgets.