chore: drop ie11 support from babel/swc and e2e tests - #7113
Draft
shaejaz wants to merge 8 commits into
Draft
Conversation
Up to standards ✅🟢 Issues
|
More templates
algoliasearch-helper
instantsearch-ui-components
instantsearch.css
instantsearch.js
react-instantsearch
react-instantsearch-core
react-instantsearch-nextjs
react-instantsearch-router-nextjs
vue-instantsearch
commit: |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes legacy IE11 support across the monorepo by switching build targets to modern defaults and deleting the WebdriverIO/Sauce Labs E2E stack in favor of Playwright-only E2E coverage.
Changes:
- Drop IE11 as an explicit compilation/stylelint target (Babel, SWC, stylelint, Browserslist templates/examples).
- Remove WebdriverIO/Sauce Labs E2E configs, helpers, and CI jobs; keep Playwright as the sole E2E framework.
- Clean up Vue InstantSearch internal polyfill usage by replacing
_objectSpreadwith native object spread /Object.assign.
Reviewed changes
Copilot reviewed 74 out of 78 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| yarn.lock | Removes WDIO/Sauce-related dependency graph entries after E2E stack deletion. |
| tests/e2e/wdio.saucelabs.conf.js | Deletes Sauce Labs WDIO configuration (incl. IE11 capability). |
| tests/e2e/wdio.local.conf.js | Deletes local WDIO configuration. |
| tests/e2e/wdio.base.conf.js | Deletes shared WDIO base config (static server + Jasmine setup). |
| tests/e2e/tsconfig.json | Deletes WDIO-era TS config (webdriverio/jasmine types). |
| tests/e2e/specs/price-range.spec.ts | Removes WDIO spec (superseded by Playwright suite). |
| tests/e2e/specs/pagination.spec.ts | Removes WDIO spec (superseded by Playwright suite). |
| tests/e2e/specs/initial-state-from-route.spec.ts | Removes WDIO spec (superseded by Playwright suite). |
| tests/e2e/specs/category.spec.ts | Removes WDIO spec (superseded by Playwright suite). |
| tests/e2e/specs/brand-and-query.spec.ts | Removes WDIO spec (superseded by Playwright suite). |
| tests/e2e/README.md | Updates E2E docs to Playwright-only and new run instructions. |
| tests/e2e/playwright/tsconfig.json | Tightens TS config for Playwright-only type-checking. |
| tests/e2e/package.json | Removes WDIO/Jasmine deps and switches type-check to Playwright tsconfig. |
| tests/e2e/index.js | Removes exported WDIO configs (local/saucelabs). |
| tests/e2e/helpers/waitForElement.ts | Removes WDIO custom command helper. |
| tests/e2e/helpers/setSortByValue.ts | Removes WDIO custom command helper. |
| tests/e2e/helpers/setSearchBoxValue.ts | Removes WDIO custom command helper. |
| tests/e2e/helpers/setHitsPerPage.ts | Removes WDIO custom command helper. |
| tests/e2e/helpers/selectors.ts | Removes WDIO selector helper module. |
| tests/e2e/helpers/index.ts | Removes WDIO helper registration entrypoint. |
| tests/e2e/helpers/getToggleRefinementStatus.ts | Removes WDIO custom command helper. |
| tests/e2e/helpers/getTextFromSelector.ts | Removes WDIO custom command helper. |
| tests/e2e/helpers/getSortByValue.ts | Removes WDIO custom command helper. |
| tests/e2e/helpers/getSelectedRefinementListItem.ts | Removes WDIO custom command helper. |
| tests/e2e/helpers/getSelectedRatingMenuItem.ts | Removes WDIO custom command helper. |
| tests/e2e/helpers/getSelectedHierarchicalMenuItems.ts | Removes WDIO custom command helper. |
| tests/e2e/helpers/getSearchBoxValue.ts | Removes WDIO custom command helper. |
| tests/e2e/helpers/getRangeSliderUpperBoundValue.ts | Removes WDIO custom command helper. |
| tests/e2e/helpers/getRangeSliderLowerBoundValue.ts | Removes WDIO custom command helper. |
| tests/e2e/helpers/getHitsTitles.ts | Removes WDIO custom command helper. |
| tests/e2e/helpers/getHitsPerPage.ts | Removes WDIO custom command helper. |
| tests/e2e/helpers/getCurrentPage.ts | Removes WDIO custom command helper. |
| tests/e2e/helpers/dragRangeSliderUpperBoundTo.ts | Removes WDIO drag helper (IE-focused URL-waiting). |
| tests/e2e/helpers/dragRangeSliderLowerBoundTo.ts | Removes WDIO drag helper (IE-focused URL-waiting). |
| tests/e2e/helpers/dragAndDropByOffset.ts | Removes WDIO drag-and-drop workaround helper. |
| tests/e2e/helpers/clickToggleRefinement.ts | Removes WDIO click helper. |
| tests/e2e/helpers/clickRefinementListItem.ts | Removes WDIO click helper. |
| tests/e2e/helpers/clickRatingMenuItem.ts | Removes WDIO click helper. |
| tests/e2e/helpers/clickPreviousPage.ts | Removes WDIO pagination helper. |
| tests/e2e/helpers/clickPage.ts | Removes WDIO pagination helper. |
| tests/e2e/helpers/clickNextPage.ts | Removes WDIO pagination helper. |
| tests/e2e/helpers/clickHierarchicalMenuItem.ts | Removes WDIO click helper. |
| tests/e2e/helpers/clickClearRefinements.ts | Removes WDIO clear-refinements helper. |
| tests/e2e/flavors.js | Removes WDIO flavor filtering logic (incl. IE11-only JS flavors). |
| tests/e2e/CONTRIBUTING.md | Updates contributor docs to Playwright-only workflow. |
| tests/e2e/all-flavors.spec.ts | Removes WDIO suite aggregator. |
| scripts/wdio/saucelabs.conf.js | Removes root WDIO Sauce Labs entrypoint. |
| scripts/wdio/local.conf.js | Removes root WDIO local entrypoint. |
| scripts/build/rollup.plugins.mjs | Updates SWC env targets from ie >= 11 to defaults. |
| packages/vue-instantsearch/src/util/polyfills.js | Deletes _objectSpread polyfill file. |
| packages/vue-instantsearch/src/util/createInstantSearchComponent.js | Replaces _objectSpread usage with native object spread. |
| packages/vue-instantsearch/src/mixins/widget.js | Replaces _objectSpread usage with Object.assign. |
| packages/vue-instantsearch/src/connectors/connectStateResults.js | Replaces _objectSpread copies with native object spread. |
| packages/vue-instantsearch/src/components/StateResults.vue | Replaces _objectSpread usage with native object spread. |
| packages/vue-instantsearch/src/components/DynamicWidgets.js | Replaces _objectSpread usage with plain object literals. |
| packages/react-instantsearch-router-nextjs/package.json | Removes test:e2e:saucelabs script alias. |
| packages/react-instantsearch-router-nextjs/e2e.d.ts | Removes WDIO/Jasmine type references. |
| packages/react-instantsearch-nextjs/package.json | Removes test:e2e:saucelabs script alias. |
| packages/instantsearch.js/src/lib/routers/history.ts | Updates comment to remove IE11 rationale and clarify origin rebuild. |
| packages/instantsearch.css/.stylelintrc.json | Removes ie 11 from unsupported-feature browser list. |
| packages/create-instantsearch-app/src/templates/Vue InstantSearch/package.json | Updates Browserslist template away from legacy IE exclusions. |
| packages/create-instantsearch-app/src/templates/InstantSearch.js widget/package.json.hbs | Removes IE 11 from template Browserslist. |
| packages/create-instantsearch-app/e2e/snapshots/templates.test.js.snap | Updates snapshots to match template Browserslist changes. |
| package.json | Removes WDIO-based E2E scripts and WDIO devDependencies. |
| examples/vue/ssr/.browserslistrc | Updates example Browserslist away from IE-era config. |
| examples/vue/media/package.json | Removes IE11 from example Browserslist string. |
| examples/vue/getting-started/package.json | Removes IE11 from example Browserslist string. |
| examples/vue/e-commerce/package.json | Removes IE11 from example Browserslist string. |
| examples/vue/default-theme/package.json | Removes IE11 from example Browserslist string. |
| examples/js/e-commerce/index.html | Removes polyfills.js script include. |
| examples/js/e-commerce-umd/index.html | Removes polyfills.js script include. |
| CONTRIBUTING.md | Updates repo-wide E2E documentation to Playwright-only commands. |
| babel.config.js | Switches Storybook preset-env target from IE11 to defaults. |
| .oxlintrc.json | Removes WDIO/Jasmine-specific lint overrides; keeps E2E override for Playwright folder. |
| .claude/rules/e2e.md | Updates internal E2E guide to state Playwright-only and removes IE11 section. |
| .circleci/config.yml | Removes the IE11 E2E job from workflows and job definitions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Haroenv
reviewed
Jul 21, 2026
| import { createPaginationTestSuite } from './specs/pagination.spec'; | ||
| import { createPriceRangeTestSuite } from './specs/price-range.spec'; | ||
|
|
||
| getFilteredFlavors(browser).forEach((flavor) => { |
Contributor
There was a problem hiding this comment.
do these tests all have equivalents in playwright?
Contributor
Author
There was a problem hiding this comment.
yes, they exist in the tests/e2e/playwright/specs/ dir.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FX-3781