fix: handle stale login redirect contexts (#183)#288
Open
tomaspinkas-com wants to merge 1 commit into
Open
Conversation
|
|
tomaspinkas-com
force-pushed
the
fix/login-stale-context-183
branch
from
3fc9c87 to
c44c161
Compare
tomaspinkas-com
force-pushed
the
fix/login-stale-context-183
branch
from
c44c161 to
39b71e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$## Summary
last_contextbefore using it as a signed-in redirect target/{org}/dashboard/homewhen the saved handle is stale or points at an individual userWhy
Issue #183 reports users getting redirected to an old GitHub handle after renaming their account, which leads to a 404 after login. The redirect logic trusted
last_contextblindly and treated any handle as an org dashboard target.Fixes #183