-
-
Notifications
You must be signed in to change notification settings - Fork 359
Add devcontainer setup for Elm and fix Euler Elm example #911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add devcontainer setup for Elm and fix Euler Elm example #911
Conversation
It seems to me the elm script I picked to test this is incompatible with the current version of elm. Not sure why they would change the whole process but did you get any elm to run with the binaries that are installed? Also the binaries work fine but it feels weird to merge if they can't run our elm. |
The Elm contribution is mine, it's written in Elm 0.18, since then 0.19.1 came out, and that's the version of the binary. |
I don't know anything about Elm, I think the Elm script didn't work on my end either, but I figured it installed properly so it was good enough. Has Elm changed that much between versions? |
I believe that would solve the issue. Thanks for being willing to update |
Yeah, there were a bunch of breaking changes from 0.18 to 0.19, but 0.19 is supposed to be stable. Elm is a frontend development language, so it's not something you can run as is like a script. You can use the |
Is it cool to push to this branch? I'm afraid very few people know Elm, so waiting for a review would take ages. However, this is just an update, I had to change to different packages, etc, but the algorithm itself wasn't touched at all. If you run |
Yes it's okay. I'll review later today |
Okay great news! This certainly runs. I have no clue how to review if it "works" from an algo perspective. Here is the output. @leios or someone else with good math skills please run this (after unzipping) wiht something like
The dev container works though. |
@jiegillet I found a bug where when you press |
Haha whoops, that was just me being sloppy, 0.18 or 0.19. I fixed it :) |
Add setup for Elm, part of #871