Metal:Bugfix: Fix bug for read float external bias error#4277
Merged
wangzhaode merged 1 commit intoalibaba:masterfrom Mar 20, 2026
Merged
Metal:Bugfix: Fix bug for read float external bias error#4277wangzhaode merged 1 commit intoalibaba:masterfrom
wangzhaode merged 1 commit intoalibaba:masterfrom
Conversation
bitxsw93
approved these changes
Mar 19, 2026
| @@ -29,7 +29,7 @@ | |||
| if(static_cast<MetalBackend*>(backend)->getMemoryMode() == BackendConfig::Memory_Low) { | |||
| if (conv2D->quanParameter() && (conv2D->external() || conv2D->quanParameter()->buffer())) { | |||
| // quant type equal to 3 means fp16, fallback to float weight | |||
| if(conv2D->quanParameter()->type() != 3) { | |||
| if(conv2D->quanParameter()->type() != 3 && conv2D->quanParameter()->type() != 8) { | |||
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修正 metal 后端运行 float 的权重分离模型时出错的问题