fix(sdk): sanitize generated Harbor job names#1031
Draft
xdlkc wants to merge 1 commit into
Draft
Conversation
Reject explicit Harbor job names containing path separators and strip dataset/task prefixes when auto-generating names. Co-Authored-By: Codex <noreply@openai.com> AI-Model: GPT-5 Codex AI-Contributed/Feature: 6/6 AI-Contributed/UT: 0/0
xdlkc
force-pushed
the
feature/harbor-job-name-sanitize
branch
from
b28ccf7 to
a748293
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
job_namevalues that contain/Why
Harbor job names are used as flat identifiers and path components in downstream job handling. Preserving slash-separated dataset/task identifiers can produce path-like job names and break consumers that expect a single flat name segment.
Fixes #1030
Validation
git diff --check/Users/keluo/Code/rock-keluo/.venv/bin/python -m pytest tests/unit/sdk/job/test_config.py::TestHarborJobConfigAutoJobName -q-> 4 passedsuite/my-dataset+group/my-taskgeneration andbad/namevalidation