feat(ci): add changelog generation workflow and PR lint gate#88
Open
kongche-jbw wants to merge 1 commit intoalibaba:mainfrom
Open
feat(ci): add changelog generation workflow and PR lint gate#88kongche-jbw wants to merge 1 commit intoalibaba:mainfrom
kongche-jbw wants to merge 1 commit intoalibaba:mainfrom
Conversation
358ebb7 to
75e81e1
Compare
75e81e1 to
8be6bb8
Compare
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix several bugs and inconsistencies in the CI configuration across the changelog
generation workflow and the PR lint gate.
Key fixes:
cliff.tomlwas silently producing wrong version headers (e.g.cosh/v1.0.0instead of
1.0.0) due totrim_start_matchesnot handling the monorepo tagprefix. Fixed via
split(pat="/") | last.chore/changelog-*branches created bychangelog.ymlwere being rejected bythe
branch-namejob inprelint.yml, breaking the automated CHANGELOG PR flow.release/**PRs were not covered by lint at all (missing trigger branch).isIntegrationToMain && false) was removed and the collaborative-tracknote is now expressed as a plain comment.
Related Issue
closes feat(ci): add changelog generation workflow and PR lint gate #87
Type of Change
Scope
cosh(copilot-shell)agent-sec-coreos-skillsagentsightChecklist
cosh: Lint passes, type check passes, and tests passagent-sec-core(Rust):cargo clippy -- -D warningsandcargo fmt --checkpassagent-sec-core(Python): Ruff format and pytest passos-skills: Skill directory structure is valid and shell scripts pass syntax checkpackage-lock.json/Cargo.lock)Testing
CI-only changes. Verified by:
prelint.ymlagainstchore/changelog-*,release/*, and standardfeature/fix/hotfixbranches.cliff.tomlTera template output for tags in<scope>/v<x.y.z>format.Additional Notes
git-cliffis now pinned tov2.4.0. UpdateVERSIONinchangelog.ymlintentionally when upgrading.merge:commitlabel referenced inmerge-hintmust be created in the GitHub repo's label settings before it can be applied automatically.