feat: support suspense event #7053
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
answershuto
reviewed
Feb 21, 2025
| @@ -156,6 +156,11 @@ export function withSuspense(Component) { | |||
| <SuspenseContext.Provider value={suspenseState}> | |||
| <Component {...componentProps} /> | |||
| <Data id={id} /> | |||
| <script | |||
| dangerouslySetInnerHTML={{ | |||
| __html: `performance && typeof performance.mark === "function" && performance.mark("ice-suspense-loaded", { detail: "suspense:${id}" })`, | |||
There was a problem hiding this comment.
我建议是只派发不在这里做实际的“行为”。
比如如果后面的需求改成了“每个边界中所有图片加载完成”的耗时的 mark，那应该怎么改？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6994
改为使用
performance.mark以避免事件监听时可能存在的时序问题