Skip to content

[ISSUE #15416] Support Nacos-managed skill subscriptions#15417

Open
saynoword wants to merge 16 commits into
alibaba:developfrom
saynoword:feat/subscribe-skill
Open

[ISSUE #15416] Support Nacos-managed skill subscriptions#15417
saynoword wants to merge 16 commits into
alibaba:developfrom
saynoword:feat/subscribe-skill

Conversation

@saynoword

Copy link
Copy Markdown
Contributor

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

Add Nacos-managed skill subscriptions so users can maintain per-user, per-namespace skill subscription lists from Nacos and let CLI registry mode read the current user's subscription list. This stores subscriptions in Config without adding a new table, exposes admin/console management APIs plus a client read API, and wires the old console and next console subscription workflows. Closes #15416.

Brief changelog

  • Add skill subscription API models, Config-backed storage, admin subscription service, and current-user client subscription read service.
  • Add admin APIs for listing, subscribing, and unsubscribing skills, plus a client API that only reads the current request user's subscriptions.
  • Wire console maintainer/inner/noop handlers and old console skill management subscription UI.
  • Add next console subscription state, single and batch subscription actions, "My subscriptions" filtering, skill detail subscription controls, and synced static assets.
  • Update skill specs, API surface docs, OpenAPI scenario coverage, and targeted unit/API tests.

Verifying this change

  • mvn -pl api,ai,maintainer-client,test/openapi-test -DskipTests spotless:apply
  • mvn -pl api,ai,maintainer-client,test/openapi-test -DskipTests spotless:check
  • mvn -pl ai -am -Dtest=SkillAdminControllerTest,SkillSubscriptionServiceImplTest,ConfigSkillSubscriptionStorageTest -Dsurefire.failIfNoSpecifiedTests=false test
  • mvn -pl console -am -Dtest=ConsoleSkillControllerTest,SkillProxyTest,SkillInnerHandlerTest,SkillRemoteHandlerTest -Dsurefire.failIfNoSpecifiedTests=false test
  • mvn -pl ai -am -Dtest=SkillClientControllerTest,ConfigSkillSubscriptionStorageTest,SkillSubscriptionServiceImplTest,SkillClientSubscriptionServiceImplTest -Dsurefire.failIfNoSpecifiedTests=false test
  • mvn -pl test/openapi-test -DskipTests test-compile
  • npx eslint src/pages/skillManagement/index.tsx

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check spotbugs:check -DskipTests to make sure basic checks pass. Run mvn clean install to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@github-actions

Copy link
Copy Markdown

Thanks for your this PR. 🙏
Please check again for your PR changes whether contains any usage/api/configuration change such as Add new API , Add new configuration, Change default value of configuration.
If so, please add or update documents(markdown type) in docs/next/ for repository nacos-group/nacos-group.github.io


感谢您提交的PR。 🙏
请再次查看您的PR内容,确认是否包含任何使用方式/API/配置参数的变更,如:新增API新增配置参数修改默认配置等操作。
如果是,请确保在提交之前,在仓库nacos-group/nacos-group.github.io中的docs/next/目录下添加或更新文档(markdown格式)。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Nacos-managed skill subscriptions

1 participant