fix: fix std::string_view cast for clang-tidy-check#205
Merged
lucasfang merged 2 commits intoalibaba:mainfrom Apr 2, 2026
Merged
fix: fix std::string_view cast for clang-tidy-check#205lucasfang merged 2 commits intoalibaba:mainfrom
lucasfang merged 2 commits intoalibaba:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates a unit test to construct std::string_view using brace-initialization, addressing a clang-tidy complaint about the prior cast-style construction.
Changes:
- Replace
std::string_view(test_stringX)withstd::string_view{test_stringX}inBinaryRowTest. - Keep the serialization test logic unchanged while adjusting construction style for clang-tidy compliance.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lszskye
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #xxx
Tests
API and Format
Documentation
Generative AI tooling