Add result token pool (#137) #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sczyh30
added
kind/enhancement
|
The CI build failed. Could you please fix it? |
louyuting
approved these changes
Apr 29, 2020
|
Thanks for contributing! However this seems not elegant enough and may bring boilerplate code. We need to open a new issue to improve this. |
|
And looking forward to more contributions :) |
Yes, It should be improve. |
|
Yes, I think so, I have seen the new issue, I will try to contribute it。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
I want to modify the original code as little as possible, but now it exists a lot of temporary token result, so my modify will look very ugly, as shown below。
Does this pull request fix one issue?
#137
Describe how you did it
Describe how to verify it
Special notes for reviews