Skip to content

Added constexpr SHA-3 Algorithm Implementation, etc.#903

Open
refvalue wants to merge 7 commits intoalibaba:mainfrom
refvalue:sha3_constexpr
Open

Added constexpr SHA-3 Algorithm Implementation, etc.#903
refvalue wants to merge 7 commits intoalibaba:mainfrom
refvalue:sha3_constexpr

Conversation

@refvalue
Copy link
Copy Markdown
Contributor

@refvalue refvalue commented Feb 14, 2025

Why

New feature: constexpr SHA-3 Algorithm Implementation.
A fundamental support for byte-array-to-hex-meta_string.

What is changing

Added constexpr SHA-3 Algorithm Implementation.
Added support for conversions from a byte array to a hex meta string.
Added some numeric conversion utilities.
Added some constexpr math functions.

Example

//refvalue::meta_string{"4ACB502EEC4FE8ECDA6E0A8D386FFE6B9B24B8CE2E22F6C8ABC729EC521D361CD883044B720458DCC7472906CC49D9D5"}

constexpr auto hash = to_hexadecimal_meta_string(sha3_digest<sha3_type::sha3_384>( "Whenever you want to, I can help.");

Added some numeric conversion utilities.
Added some constexpr math functions.
Added some numeric conversion utilities.
Added some constexpr math functions.
@github-actions
Copy link
Copy Markdown

for detail, goto summary download Artifacts base-ylt-cov-report(base commit coverage report) and ylt-cov-report(current pull request coverage report)

@github-actions
Copy link
Copy Markdown

for detail, goto summary download Artifacts base-ylt-cov-report(base commit coverage report) and ylt-cov-report(current pull request coverage report)

@github-actions
Copy link
Copy Markdown

for detail, goto summary download Artifacts base-ylt-cov-report(base commit coverage report) and ylt-cov-report(current pull request coverage report)

@github-actions
Copy link
Copy Markdown

for detail, goto summary download Artifacts base-ylt-cov-report(base commit coverage report) and ylt-cov-report(current pull request coverage report)

@github-actions
Copy link
Copy Markdown

for detail, goto summary download Artifacts base-ylt-cov-report(base commit coverage report) and ylt-cov-report(current pull request coverage report)

@poor-circle
Copy link
Copy Markdown
Collaborator

Please fix windows ci

@github-actions
Copy link
Copy Markdown

for detail, goto summary download Artifacts base-ylt-cov-report(base commit coverage report) and ylt-cov-report(current pull request coverage report)

@refvalue
Copy link
Copy Markdown
Contributor Author

Please fix windows ci

OK all checks have passed

@qicosmos
Copy link
Copy Markdown
Collaborator

I think the code is good.

But namespace is a problem, sha-3 is a util component, i think put it in ylt::util namespace is better, please add util namespace to sha-3.

BTW, refvalue::meta_string should also be ylt::util::meta_string, and then we can unify the namespace. Maybe you can modify it in this PR or next PR.

@refvalue
Copy link
Copy Markdown
Contributor Author

I think the code is good.

But namespace is a problem, sha-3 is a util component, i think put it in ylt::util namespace is better, please add util namespace to sha-3.

BTW, refvalue::meta_string should also be ylt::util::meta_string, and then we can unify the namespace. Maybe you can modify it in this PR or next PR.

OK and I will update this PR later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants