Feature/mi 255 fix types for optional request body #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a test for a post request with optional requestBody - Modify requestBody inference to pass - Minor cleanup of types
tvhees
requested review from
Zigr1,
alan-chen-aligent,
jacob-ling-aligent,
kai-nguyen-aligent and
toddhainsworth
and removed request for
a team
jacob-ling-aligent
approved these changes
Aug 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the proposed changes
This PR fixes an issue with type inference for optional requestBody specs.
Previously an optional requestBody would be treated as none at all - leading to invalid type errors for operations like
POST catalog/products/metafields.I've also tidied and documented a number of types for continuous improvement purposes.
Notes to reviewers
🛈 When you've finished leaving feedback, please add a final comment to the PR tagging the author, letting them know that you have finished leaving feedback