Skip to content

Conversation

@porhkz
Copy link
Contributor

@porhkz porhkz commented Nov 13, 2025

Description of the proposed changes

  • Readme tweaks and fixes
  • Added a deploy and extra-arguments input
  • Corrected checking if deploy from context-values input to deploy input. It was previously thought that the context-values input was to be used similar to how we use CDK_EXTRA_ARGS: in our current Bitbucket Pipeline for cdk deployments

Screenshots (if applicable)

  • N/A

Other solutions considered (if any)

  • N/A

Notes to PR author

  • Testing was attempted via act, but the NocoDB repo that was being tested faced complications with the way the actual repo built using esbuild.

⚠️ Please make sure the changes adhere to the guidelines mentioned in our contribution guide.

Notes to reviewers

ℹ️ When you've finished leaving feedback, please add a final comment to the PR tagging the author, letting them know that you have finished leaving feedback

@porhkz porhkz changed the title Chore/do 1743 updating aws cdk deploy workflow Updating readme Nov 13, 2025
@porhkz porhkz marked this pull request as draft November 13, 2025 02:27
@porhkz porhkz changed the title Updating readme Updating readme and correcting inputs Nov 19, 2025
@porhkz porhkz marked this pull request as ready for review November 19, 2025 07:14
@porhkz porhkz requested a review from TheOrangePuff November 21, 2025 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants