[ORT] Auto-detection for CUDA and ROCM path#6093
Merged
davidrohr merged 12 commits intoalisw:masterfrom Jan 23, 2026
Merged
Conversation
davidrohr
requested changes
Jan 22, 2026
Contributor
davidrohr
left a comment
davidrohr
left a comment
There was a problem hiding this comment.
Yes, nice, this is in principle what I meant, but I think we need to still improve some things:
davidrohr
reviewed
Jan 22, 2026
ktf
reviewed
Jan 22, 2026
ktf
reviewed
Jan 22, 2026
| if [[ "${PKG_VERSION}" =~ (^|-)rocm_arch@ ]]; then | ||
|
|
||
| ### ROCm | ||
| if [[ "${O2_GPU_ROCM_AVAILABLE}" == "1" && "${PKG_VERSION}" =~ rocm_home@([^@]*)@ ]]; then |
Member
There was a problem hiding this comment.
O2_GPU_ROCM_AVAILABLE can be grouped, no?
Contributor
There was a problem hiding this comment.
It could, but then I think the else statements have to cover more cases
Collaborator
Author
There was a problem hiding this comment.
Comment by David after I originally did the grouping: "I don't understand why you restructure it so much, can't you just add another block". So I kept the block structure. I don't care which way we go.
Co-authored-by: Giulio Eulisse <10544+ktf@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.