Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Adds `StreamingDataLoader` class following the OLMo-core definition, and changes `grpo_fast.py` to use it. #1202

Diff view

Diff view

There are no files selected for viewing

Uh oh!

Adds StreamingDataLoader class following the OLMo-core definition, and changes grpo_fast.py to use it. #1202

Are you sure you want to change the base?

Adds StreamingDataLoader class following the OLMo-core definition, and changes grpo_fast.py to use it. #1202

Uh oh!

Uh oh!

Diff view

Diff view

There are no files selected for viewing

Uh oh!

Adds `StreamingDataLoader` class following the OLMo-core definition, and changes `grpo_fast.py` to use it. #1202

Adds `StreamingDataLoader` class following the OLMo-core definition, and changes `grpo_fast.py` to use it. #1202