Overhaul Address

[Kenzzer]

Another Address PR!

The idea and implementation is primarily @dvander's, this PR just makes the bridge to SM.
In order to use the new virtual address :

#define VIRTUAL_ADDRESS
#include <sourcemod>
#include <sdktools>

If enabled, plugins need to ensure their SDKCalls are using the new SDKType_VirtualAddress, whether they're on 32bits or 64bits. Otherwise the plugin will most definitively crash the server.

Marking as draft for now until I can get a few server operators to try this out. Extra natives idea are welcomed !

[rtldg]

Can you also add this:

		} else if (vc->retinfo->vtype == Valve_VirtualAddress) {
			void *addr = (void *)vc->retbuf;
			return g_pSM->ToPseudoAddress(addr);
		} else {

to here

sourcemod/extensions/sdktools/vcaller.cpp

Lines 532 to 545 in b71d3c0

	} else if (vc->retinfo->vtype == Valve_Bool) {
	bool *addr = (bool *)vc->retbuf;
	if (vc->retinfo->flags & PASSFLAG_ASPOINTER)
	{
	addr = *(bool **)addr;
	}
	return *addr ? 1 : 0;
	} else {
	cell_t *addr = (cell_t *)vc->retbuf;
	if (vc->retinfo->flags & PASSFLAG_ASPOINTER)
	{
	addr = *(cell_t **)addr;
	}
	return *addr;

This would allow things like calling CreateInterface with SDKCall() and actually having a usable result.

[Headline]

@Kenzzer @rtldg anything else you guys can think of? Going to mark ready for review - plugin interface would instead be

#include <sourcemod>
#include <sdktools>
#include <virtual_address>

[Kenzzer]

I think this is great, and indeed much better than the define.

[Kenzzer]

A big thanks to @Malifox for taking the first step into trying this PR with a well established plugin, which helped me hunt down a ton of bugs.