New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dhooks x64 crash in UpdateRegisterArgumentSizes() for #2282 #2290

Open

rtldg wants to merge 1 commit into alliedmodders:master from rtldg:dhooksx64crashfix2

Contributor

rtldg commented Mar 2, 2025

From #2282

If you construct a thiscall DynamicDetour and don't add any parameters then ConstructCallingConvention() will prepend the this arg/register to vecArgTypes and UpdateRegisterArgumentSizes() will try to index through (an empty) setup->params for the size of vecArgTypes.

Not a pretty fix but it should work...

Also removed the ifdef WIN32 wrapper around the origin since this will also affect linux64.


          Fix dhooks x64 crash in UpdateRegisterArgumentSizes() for alliedmodde…

c75cb0c

…rs#2282

rtldg mentioned this pull request

DHooks x64 Linux enabler #2292

Draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet