Open
Conversation
allisterb
requested changes
Sep 21, 2020
Owner
allisterb
left a comment
There was a problem hiding this comment.
Hi thanks for this patch and sorry about the delay responding. Only minor issue I have is if AnyIdentifierChar and AnyIdentifier can be moved from the Core Grammar to the Nugetv2 grammar as I try to avoid changing the Core grammar unless absolutely needed. Other than that everything looks great. As soon as this is commited I'll update the NuGet package and the DevAudit build should pick up the changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created this crude update to fix handling of version numbering containing multiple dashes.
This update supports:
This update does not support:
I also changed the argument order in the tests to match expected vs result.