Skip to content

Commit

Permalink
Removing gcloud auth until we really need it. (#3)
Browse files Browse the repository at this point in the history
Kicking the can down the road...
  • Loading branch information
alxmrs authored Jun 23, 2024
1 parent 013368d commit 78c2aee
Show file tree
Hide file tree
Showing 4 changed files with 23 additions and 8 deletions.
13 changes: 7 additions & 6 deletions .github/workflows/ci-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,12 +57,13 @@ jobs:
run: |
pip install -e .[tests]
- uses: 'actions/checkout@v4'
- id: 'auth'
name: 'Authenticate to Google Cloud'
uses: 'google-github-actions/auth@v1'
with:
service_account: ${{ secrets.SERVICE_ACCOUNT }}
workload_identity_provider: ${{ secrets.WORKLOAD_IDENTITY_PROVIDER }}
# # TODO(alxmrs): Add back gcloud auth, when it's needed.
# - id: 'auth'
# name: 'Authenticate to Google Cloud'
# uses: 'google-github-actions/auth@v1'
# with:
# service_account: ${{ secrets.SERVICE_ACCOUNT }}
# workload_identity_provider: ${{ secrets.WORKLOAD_IDENTITY_PROVIDER }}
- name: Run unit tests
run: |
pytest dee
2 changes: 1 addition & 1 deletion conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@
try:
app.run(lambda argv: None)
except SystemExit:
pass
pass
2 changes: 1 addition & 1 deletion dee/__init__.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
# TODO(alxmrs): https://docs.google.com/document/d/1Ltl6XrZ_uGD2J7OW1roUsxhpFxx5QvNeInjuONIkmL8/edit#heading=h.uj7plawe7x7e
# TODO(alxmrs): https://docs.google.com/document/d/1Ltl6XrZ_uGD2J7OW1roUsxhpFxx5QvNeInjuONIkmL8/edit#heading=h.uj7plawe7x7e
14 changes: 14 additions & 0 deletions dee/default_test.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
import unittest


class ImportTest(unittest.TestCase):

def test_can_import_dee(self):
try:
import dee
except ModuleNotFoundError:
self.fail('Cannot import `dee`.')


if __name__ == '__main__':
unittest.main()

0 comments on commit 78c2aee

Please sign in to comment.